Repository navigation
fix(aws): Don't crash if event isn't a single dict - #915
Merged
Merged
Conversation
lobsterkatie
force-pushed
the
kmclb-fix-batch-events-aws
branch
from
November 10, 2020 01:40
75ba258 to
a406aa6
Compare
untitaker
reviewed
Nov 10, 2020
untitaker
approved these changes
Nov 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://docs.aws.amazon.com/lambda/latest/dg/python-handler.html, the
eventargument passed to the lambda function handler can be any jsonifiable type - string, int, list, etc - rather than just the dictionary we've previously assumed it to be. (This is particularly relevant for batch requests, which come in as a list of event dictionaries.)When faced with such an
event, our current integration crashes, because it tries to run.get()on it. This fixes that, by introducing the following behavior:eventis a list, tag the transaction as a batch and with the batch size.eventis a list, take the first entry as representative for the purposes of grabbing request data.event(or the representative) isn't a dictionary, handle it gracefully and move on without request data.Fixes #891.