feat(tracing): Add aiohttp request object to sampling context#888
Merged
Conversation
lobsterkatie
force-pushed
the
kmclb-aiohttp-sampling-context
branch
from
October 22, 2020 18:33
2e7ade6 to
e2fc20d
Compare
lobsterkatie
force-pushed
the
kmclb-aiohttp-sampling-context
branch
from
October 26, 2020 22:56
e2fc20d to
d9da850
Compare
untitaker
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #863, this adds the request object to the data automatically passed to
traces_samplerwhen using the AIOHTTP integration.