You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This adds a pointer to the Span class which points the the Transaction instance from which the span is descended. (It doesn't do anything with it yet, though - that will come in a subsequent PR which allows unsampled transactions living on the scope to be found.)
For reference, the WIP Go implementation always records the span tree, no matter what the sampling decision is.
Would be curious if that has any negative implication, or otherwise we could do the same in Python and JS to eliminate having "yet-another-way" to store references to spans.
For reference, the WIP Go implementation always records the span tree, no matter what the sampling decision is.
Would be curious if that has any negative implication, or otherwise we could do the same in Python and JS to eliminate having "yet-another-way" to store references to spans.
This seems better to me for two reasons:
Why take up memory storing a span tree if we're not going to keep its data? This does make span trees we keep a teeny bit heavier while we're building them, but on the balance it's still a memory savings unless the sample rate is super high.
self._span_recorder[0] is a pretty darn opaque way to say "the transaction to which this span belongs," and feels more on the level of implementation detail than ideally even an internal API would be (IMHO).
lobsterkatie
changed the title
[WIP] feat(tracing): Make spans point to their transactions
feat(tracing): Make spans point to their transactions
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a pointer to the
Spanclass which points the theTransactioninstance from which the span is descended. (It doesn't do anything with it yet, though - that will come in a subsequent PR which allows unsampled transactions living on the scope to be found.)