ref(tests): Split up tracing tests#857
Merged
Merged
Conversation
flub
approved these changes
Oct 13, 2020
lobsterkatie
force-pushed
the
kmclb-split-up-tracing-tests
branch
from
October 13, 2020 15:52
00f9472 to
ae19278
Compare
lobsterkatie
force-pushed
the
kmclb-split-up-tracing-tests
branch
from
October 13, 2020 15:59
859b8c9 to
d101fdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracing test file was already getting long, and I'm about to add a bunch of new tests. Zero behavior change here - literally just a copy-paste job.
(Enough of the tests from the old
test_tracing.pyended up in the newtracing/test_integration_tests.pythat git is calling it a rename-with-a-bunch-of-changes, rather than a deletion of the former and creation of the latter. Unclear how to force GH intogit diff --no-renames.)