feat: Sanic integration#85
Merged
Merged
Conversation
Contributor
|
How much does this diverge from aiohttp? I wonder if we can just have an aiohttp integration that then automatically supports most of sanic. |
Member
Author
|
I haven't looked into it but aiohttp isn't a dependency of sanic. I only need it for testing. |
Member
Author
|
ping @mitsuhiko, want to get this out |
mitsuhiko
approved these changes
Sep 27, 2018
mitsuhiko
left a comment
mitsuhiko
left a comment
Contributor
There was a problem hiding this comment.
This works for me. I thought the request object came from aiohttp but evidently not.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support for older versions seems nontrivial. In particular testing against 0.7 just locks up