Repository navigation
feat(django): Filter sensitive_post_parameters from request data - #8238
Open
brianhelba wants to merge 1 commit into
Open
brianhelba wants to merge 1 commit into
brianhelba wants to merge 1 commit into
Conversation
Django's `sensitive_post_parameters` decorator marks POST parameters whose values should be kept out of error reports. Previously, the Django integration ignored it, so those values were sent to Sentry as part of the event's request data. Replace the values of the marked parameters with `[Filtered]`. This covers data in form bodies, Django REST Framework's `request.data`, and JSON object bodies. See: https://docs.djangoproject.com/en/stable/howto/error-reporting/#filtering-sensitive-information Related to getsentry#2356, but the `sensitive_variables` decorator is not handled by this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Django's
sensitive_post_parametersdecorator marks POST parameters whose values should be kept out of error reports. Previously, the Django integration ignored it, so those values were sent to Sentry as part of the event's request data.Replace the values of the marked parameters with
[Filtered]. This covers data in form bodies, Django REST Framework'srequest.data, and JSON object bodies.See: https://docs.djangoproject.com/en/stable/howto/error-reporting/#filtering-sensitive-information
Issues
Related to #2356, but the
sensitive_variablesdecorator is not handled by this.