Skip to content

fix: Allow ASGI middleware to capture exceptions in nested call#817

Merged
untitaker merged 3 commits into
masterfrom
fix/asgi-middleware-recursive-exceptions
Sep 14, 2020
Merged

fix: Allow ASGI middleware to capture exceptions in nested call#817
untitaker merged 3 commits into
masterfrom
fix/asgi-middleware-recursive-exceptions

Conversation

@untitaker

@untitaker untitaker commented Sep 9, 2020

Copy link
Copy Markdown
Member

When the exception bubbles up we deduplicate it based on object identity, so this should be fine

Fix #816

@untitaker
untitaker merged commit ce83b95 into master Sep 14, 2020
@untitaker
untitaker deleted the fix/asgi-middleware-recursive-exceptions branch September 14, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

last_event_id() returns None after SentryAsgiMiddleware.__call__() finished

1 participant