Skip to content

fix: Refactor testsuite for GCP and fix some bugs#804

Merged
untitaker merged 12 commits into
getsentry:masterfrom
shantanu73:master
Sep 1, 2020
Merged

fix: Refactor testsuite for GCP and fix some bugs#804
untitaker merged 12 commits into
getsentry:masterfrom
shantanu73:master

Conversation

@shantanu73

@shantanu73 shantanu73 commented Aug 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Changed test_gcp.py file to include unit tests and removed automation tests.
  2. Modified tox.ini as per above changes.
  3. Modified Google cloud logs url to include utc time.

Shantanu Dhiman and others added 3 commits August 28, 2020 18:14
Shantanu Dhiman
Changes:
f135ffd 
1) Changed test_gcp.py file to include unit tests instead of automation tests.
2) Modified tox.ini as per above changes.
@shantanu73
Merge branch 'master' into master
1f1a31c
Shantanu Dhiman
Changes:
9a3c3b9 
1) Modified local time to utc time in google cloud logs url.
2) Converted log range to include log values from after the completion of execution.
@shantanu73 shantanu73 changed the title Unit test cases for Sentry Python SDK Unit test cases for Sentry Python SDK for GCP integration and Google cloud logs url modification Aug 31, 2020
Shantanu Dhiman added 2 commits September 1, 2020 11:33
Shantanu Dhiman
Changes:
88745d7 
1) Modified test_gcp.py file to skip tests python versions 2.7 & pypy for GCP integration unit test cases.
Shantanu Dhiman
Modified tox.ini file to resolve build fail for python3.7 environment
16cf50a
rhcarvalho
rhcarvalho suggested changes Sep 1, 2020
View reviewed changes
Comment thread sentry_sdk/integrations/gcp.py Outdated
rhcarvalho
rhcarvalho reviewed Sep 1, 2020
View reviewed changes
Comment thread sentry_sdk/integrations/gcp.py Outdated
Comment thread sentry_sdk/integrations/gcp.py
Comment thread sentry_sdk/integrations/gcp.py Outdated
Shantanu Dhiman and others added 7 commits September 1, 2020 16:57
Shantanu Dhiman
Changes:
3bd76d4 
1) Modified log url to include standard format for timestamp to construct log url.
2) Added code in tox.ini file to run test suite for GCP unit test cases.
Shantanu Dhiman
Fixed variable names for log url to appropriate values.
890996e
@untitaker
fix importorskip
fd63224
@untitaker
Revert "fix importorskip"
adf68cc 
This reverts commit fd63224.
@untitaker
attempt skipif fix again
ee443a9
Shantanu Dhiman
Merge branch 'master' of https://github.com/shantanu72/sentry-python
8c80167
Shantanu Dhiman
Made changes as per review comments related to variable naming and us…
0a9f28e 
…age for timestamp.
@untitaker untitaker changed the title Unit test cases for Sentry Python SDK for GCP integration and Google cloud logs url modification fix: Refactor testsuite for GCP and fix some bugs Sep 1, 2020
@untitaker
untitaker merged commit 5f426c4 into getsentry:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rhcarvalho rhcarvalho rhcarvalho approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shantanu73 @rhcarvalho @untitaker