fix(openai): Gate gen_ai.response.tool_calls on outputs, not inputs - #7205
Open
ericapisani wants to merge 1 commit into
Open
fix(openai): Gate gen_ai.response.tool_calls on outputs, not inputs#7205ericapisani wants to merge 1 commit into
gen_ai.response.tool_calls on outputs, not inputs#7205ericapisani wants to merge 1 commit into
Conversation
Tool call data is part of the model's response, so it should be recorded when `data_collection.gen_ai.outputs` is enabled, not gated on `inputs`. Previously, disabling outputs while leaving inputs enabled still collected tool calls, and disabling inputs alone dropped them even though outputs remained enabled. Refs PY-2734 Refs #7200
Contributor
Codecov Results 📊✅ 113171 passed | ⏭️ 6721 skipped | Total: 119892 | Pass Rate: 94.39% | Execution Time: 413m 2s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2483 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.20% 90.23% +0.03%
==========================================
Files 193 193 —
Lines 25423 25421 -2
Branches 9336 9336 —
==========================================
+ Hits 22933 22938 +5
- Misses 2490 2483 -7
- Partials 1436 1437 +1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool call data is part of the model's response, so it should be recorded when
data_collection.gen_ai.outputsis enabled, not gated oninputs.Refs PY-2734
Refs #7200