chore: Make enable_logs, enable_metrics no-op - #7177
Merged
Conversation
Contributor
Codecov Results 📊✅ 111388 passed | ⏭️ 6749 skipped | Total: 118137 | Pass Rate: 94.29% | Execution Time: 399m 23s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 92.86%. Project has 2484 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.17% 90.19% +0.02%
==========================================
Files 193 193 —
Lines 25317 25309 -8
Branches 9280 9272 -8
==========================================
+ Hits 22827 22825 -2
- Misses 2490 2484 -6
- Partials 1427 1428 +1Generated by Codecov Action |
sentrivana
marked this pull request as ready for review
August 12, 2026 11:49
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae82dd5. Configure here.
alexander-alderman-webb
approved these changes
Aug 12, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
We're making
enable_logsandenable_metricsno-op with this change, and they'll be dropped in the next major.There's no need for an additional hurdle for using the logs and metrics APIs -- opting to use the API is opt-in enough.
Previously,
enable_logsalso controlled automatic logs collection from the logging and Loguru integrations. These integrations now get an integration-levelcapture_sentry_logsboolean option to allow for more control over the auto-collection. These options areFalseby default, i.e., nothing is auto-collected without your explicit opt-in.If you want to enable auto-collection, do:
Issues
Closes #6195