feat: fix up sending of string types#7
Merged
Merged
Conversation
Member
Author
|
As far as I understood it's desirable to always send the repr for any string type in |
Contributor
|
@untitaker I would even go as far as proposing to send any value that is not a list/dict as repr'ed string. For instance one could make the argument that integers and bools are fine just like this, but in reality even this is wrong. For instance Python shows bools as |
mitsuhiko
reviewed
Jul 20, 2018
mitsuhiko
left a comment
mitsuhiko
left a comment
Contributor
There was a problem hiding this comment.
lgtm other than the broken test
untitaker
force-pushed
the
string-repr-vars
branch
from
July 20, 2018 14:08
620fbe3 to
84c286c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.