Skip to content

fix: Prevent sending infinity in envelopes #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untitaker merged 1 commit into from
Apr 3, 2020
Merged

fix: Prevent sending infinity in envelopes #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sentry_sdk/envelope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def serialize_into(
self, f # type: Any
):
# type: (...) -> None
f.write(json.dumps(self.headers).encode("utf-8"))
f.write(json.dumps(self.headers, allow_nan=False).encode("utf-8"))
f.write(b"\n")
for item in self.items:
item.serialize_into(f)
Expand Down Expand Up @@ -142,7 +142,7 @@ def get_bytes(self):
with open(self.path, "rb") as f:
self.bytes = f.read()
elif self.json is not None:
self.bytes = json.dumps(self.json).encode("utf-8")
self.bytes = json.dumps(self.json, allow_nan=False).encode("utf-8")
else:
self.bytes = b""
return self.bytes
Expand Down Expand Up @@ -256,7 +256,7 @@ def serialize_into(
headers = dict(self.headers)
length, writer = self.payload._prepare_serialize()
headers["length"] = length
f.write(json.dumps(headers).encode("utf-8"))
f.write(json.dumps(headers, allow_nan=False).encode("utf-8"))
f.write(b"\n")
writer(f)
f.write(b"\n")
Expand Down