Skip to content

fix: Fix typo in header name #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untitaker merged 1 commit into from
Mar 25, 2020
Merged

fix: Fix typo in header name #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sentry_sdk/transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def _update_rate_limits(self, response):

# new sentries with more rate limit insights. We honor this header
# no matter of the status code to update our internal rate limits.
header = response.headers.get("x-sentry-rate-limit")
header = response.headers.get("x-sentry-rate-limits")
if header:
self._disabled_until.update(_parse_rate_limits(header))

Expand Down
4 changes: 2 additions & 2 deletions tests/test_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def test_data_category_limits(httpserver, capsys, caplog, response_code):
httpserver.serve_content(
"hm",
response_code,
headers={"X-Sentry-Rate-Limit": "4711:transaction:organization"},
headers={"X-Sentry-Rate-Limits": "4711:transaction:organization"},
)

client.capture_event({"type": "transaction"})
Expand Down Expand Up @@ -150,7 +150,7 @@ def test_complex_limits_without_data_category(
dict(dsn="http://foobar@{}/123".format(httpserver.url[len("http://") :]))
)
httpserver.serve_content(
"hm", response_code, headers={"X-Sentry-Rate-Limit": "4711::organization"},
"hm", response_code, headers={"X-Sentry-Rate-Limits": "4711::organization"},
)

client.capture_event({"type": "transaction"})
Expand Down