feat(litestar): Set name and source on route span when streaming#6553
Open
alexander-alderman-webb wants to merge 2 commits into
Open
feat(litestar): Set name and source on route span when streaming#6553alexander-alderman-webb wants to merge 2 commits into
alexander-alderman-webb wants to merge 2 commits into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 89334 passed | ⏭️ 6013 skipped | Total: 95347 | Pass Rate: 93.69% | Execution Time: 306m 48s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 88.24%. Project has 2373 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.83% 89.87% +0.04%
==========================================
Files 192 192 —
Lines 23430 23432 +2
Branches 8050 8050 —
==========================================
+ Hits 21049 21059 +10
- Misses 2381 2373 -8
- Partials 1333 1329 -4Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Call
Scope.set_transaction_name()on isolation and current scopes instead of manually overwriting event fields in an event processor.Using the function ensures that the name and the
sentry.span.sourceattribute are set on the segment span when the streaming trace lifecycle is enabled.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)