fix(asgi): Gate query string and client IP behind send_default_pii#6501
fix(asgi): Gate query string and client IP behind send_default_pii#6501ericapisani wants to merge 4 commits into
Conversation
Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes #6499
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 666e6fb. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Codecov Results 📊✅ 89266 passed | ⏭️ 6013 skipped | Total: 95279 | Pass Rate: 93.69% | Execution Time: 300m 54s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2373 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.86% 89.87% +0.01%
==========================================
Files 192 192 —
Lines 23430 23433 +3
Branches 8050 8052 +2
==========================================
+ Hits 21056 21060 +4
- Misses 2374 2373 -1
- Partials 1329 1328 -1Generated by Codecov Action |
|
If Warden is right about
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb14dd0. Configure here.
3 participants
Move http.query and client.address attribute collection inside the
should_send_default_pii() check so sensitive values are not captured
by default.
Fixes PY-2514
Fixes #6499