Repository navigation
Conversation
untitaker
reviewed
Dec 3, 2019
nikitagashkov
force-pushed
the
bugfix/aiohttp-integration-cancelled-error
branch
from
December 3, 2019 15:40
8f76bb8 to
df8850a
Compare
untitaker
reviewed
Dec 4, 2019
| events = capture_events() | ||
| client = await aiohttp_client(app) | ||
|
|
||
| with suppress(ServerDisconnectedError): |
Member
There was a problem hiding this comment.
please use pytest.raises here unless you are saying this error does not happen all the time
Contributor
Author
There was a problem hiding this comment.
I've used suppress to avoid testing aiohttp here.
At the moment, ServerDisconnectedError is always raised, but this behavior can be changed in the future and will cause tests to fail even though sentry-python operates normally.
But, if you'd like to use pytest.raises instead, let me know :)
untitaker
approved these changes
Dec 4, 2019
untitaker
left a comment
untitaker
left a comment
Member
There was a problem hiding this comment.
one minor nit left, otherwise g2g
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables capturing of
asyncio.CancelledErrorinAioHttpIntegration.aiohttpwill raiseasyncio.CancelledErrorif clients interrupt request (ref.) and this behaviour is considered normal.In the meanwhile, such aborted requests are getting captured: