Fixed the serialization of byte-string objects in Python 3#551
Merged
untitaker merged 2 commits intoNov 11, 2019
Conversation
Note: fixed in Python 3 only
untitaker
approved these changes
Nov 11, 2019
Member
|
Solid work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #550
The serializer was returning lists of integers when attempting to serialize
bytes. On top of that, the behavior ofsentry_sdk.utils.safe_reprwas decoding non-printable characters, and generally not behaving as expected.Both issues were fixed for Python 3.
safe_reprstill has the bug in Python 2, but the solution for that will not be straightforward.