feat: Added breadcrumbs for httplib#52
Conversation
|
Since urllib3 uses httplib I wonder if this would double-log requests when using urllib3 or requests (or an older version of requests that uses stdlib urllib) |
|
|
||
| def _get_default_integrations(): | ||
| from .logging import LoggingIntegration | ||
| from .stdlib import StdlibIntegration |
There was a problem hiding this comment.
I wanted to make an stdlib integration with all the hooks against the stdlib instead of one integration per stdlib module
There was a problem hiding this comment.
ok, should we move the logging integration into this?
There was a problem hiding this comment.
I would keep that one separate because it's so special.
There was a problem hiding this comment.
Keep in mind though that if we put too much into one integration you can't enable/disable each of the "sub-integrations" one-by-one.
I don't understand why you do this though since the stdlibintegration is enabled by default anyway.
|
I don't think it dual logs as urllib3 does not use httplib i think. At least we did the same thing in the old lib and did not dual record. Will test though |
b565509 to
862ee26
Compare
862ee26 to
24a3cec
Compare
|
can't repro this bs locally so let's print out local vars |
35f678c to
8ae46fc
Compare
8ae46fc to
b8a9743
Compare
|
@mitsuhiko please check if this works on your machine. I magically managed to reproduce the travis failure this morning |
2 participants
No description provided.