Skip to content

tests: Move rq under toxgen - #4818

Merged
sentrivana merged 12 commits into
masterfrom
ivana/toxgen/rq
Sep 19, 2025
Merged

sentrivana merged 12 commits into
masterfrom
ivana/toxgen/rq

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 18, 2025 •

Copy link
Copy Markdown
Collaborator

Description

  • moved rq under toxgen 🎉 it needed quite some fiddling around with fakeredis versions but seems to work now

Issues

Ref #4506

Reminders

@codecov

codecov Bot commented Sep 18, 2025 •

Copy link
Copy Markdown

✅ All tests passed in 2555.23s

@sentrivana
sentrivana marked this pull request as ready for review September 19, 2025 10:54
@sentrivana
sentrivana requested a review from a team as a code owner September 19, 2025 10:54
cursor[bot]

This comment was marked as outdated.

@sentrivana

Copy link
Copy Markdown
Collaborator Author

Removing the test-tasks-latest GitHub Actions job unintentionally eliminated testing for the latest versions of all task integrations (arq, beam, celery, dramatiq, huey, ray, rq, spark). While the PR aimed to move only RQ to toxgen, this change resulted in a broader loss of latest-version test coverage for all these integrations.

For posterity, this is expected since rq was the last test suite in the Tasks group that was still using the old system (-latest). The other test suites under -latest were just trivially passing, they weren't actually running. With the switch to toxgen, everything is in the -pinned group instead, but we make sure to always pin the latest version to still be able to spot regressions quickly.

Moved redis under toxgen, effectively moving the whole DBs group away
from the old system.

Ref #4506

- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)
@sentrivana
sentrivana enabled auto-merge (squash) September 19, 2025 11:40
@sentrivana
sentrivana merged commit 222badb into master Sep 19, 2025
@sentrivana
sentrivana deleted the ivana/toxgen/rq branch September 19, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants