Repository navigation
feat: Add action to run toxgen periodically - #4805
Merged
Merged
Conversation
|
✅ All tests passed |
sentrivana
marked this pull request as ready for review
September 16, 2025 14:03
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
szokeasaurusrex
approved these changes
Sep 16, 2025
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Looks good! I added some minor, optional suggestions for tweaks. Feel free to use or ignore :)
| workflow_dispatch: | ||
| schedule: | ||
| # early Monday morning | ||
| - cron: '23 3 * * 1' |
Member
There was a problem hiding this comment.
Why exactly at 03:23 UTC? 😅
Collaborator
Author
There was a problem hiding this comment.
No reason for this specific time, the important part is just that it's not at :00 -- usually it's good practice to set crons to run at a different time than the start of the hour since that's when most cron jobs are running and yours might be delayed or even dropped. See also here
Member
There was a problem hiding this comment.
oh – perhaps I should change the time I am using in Sentry CLI then
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run
scripts/generate-test-files.shin a GitHub action every Monday morning and create a PR with the changes. If there are already any toxgen PRs open, close them.Here's an example run of the action: https://github.com/sentrivana/sentry-python/actions/runs/17768312844 (from a fork of the repo so that I can test it)
And an example PR: sentrivana#6
Action shamelessly stolen and adapted from sentry-cli. 🥔
Issues
Closes #4050
Reminders
tox -e linters.feat:,fix:,ref:,meta:)