ref(gnu-integration): update clickhouse stacktrace parsing#4598
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
==========================================
- Coverage 80.70% 80.66% -0.05%
==========================================
Files 156 156
Lines 16498 16496 -2
Branches 2806 2806
==========================================
- Hits 13315 13306 -9
- Misses 2295 2302 +7
Partials 888 888
|
untitaker
approved these changes
Jul 21, 2025
sentrivana
approved these changes
Jul 22, 2025
sentrivana
pushed a commit
that referenced
this pull request
Aug 12, 2025
I updated the GNU Integration in #4598 but I didn't make the path optional so if we didn't have the path included, then the stacktrace didn't get parsed: ```python # got parsed "17. DB::TCPHandler::runImpl() @ 0x00000000121bb5d8 in /usr/bin/clickhouse" # didn't get parsed "17. DB::TCPHandler::runImpl() @ 0x00000000121bb5d8" ``` So updated it so that regardless of whether the path is present it will get parsed
MeredithAnya
added a commit
to getsentry/snuba
that referenced
this pull request
Aug 15, 2025
okay so I had to add a fix (getsentry/sentry-python#4688) to the earlier change (getsentry/sentry-python#4598) I made in the sentry-python sdk. so now I'm bumping the sentry-sdk to `2.35.0` to grab that fix. I added the `update_current_span ` convenience funtion that was also in this release getsentry/sentry-python#4673 **testing:** going to test this out in S4S first before moving on to de and us
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integration was added back in 2019 #288 but I think since then the stack trace from clickhouse driver has changed, anyway I tried to update it so that it parses the stack trace again (screenshots below)
However, I do see that we have a
ClickhouseDriverIntegrationnow so I'm not sure if this functionality should be rolled up with it. I chose not to since the snuba codebase doesnt use that integration and it seemed reasonable to want the stack trace formatted without having the spans added