Repository navigation
ci: Check strictly for success - #4589
Merged
Merged
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-ci
branch
from
July 17, 2025 12:40
0bef45e to
2217c01
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4589 +/- ##
==========================================
- Coverage 80.71% 80.69% -0.02%
==========================================
Files 156 156
Lines 16507 16507
Branches 2806 2806
==========================================
- Hits 13323 13321 -2
- Misses 2296 2297 +1
- Partials 888 889 +1 |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-ci
branch
2 times, most recently
from
July 17, 2025 12:43
07868f6 to
4de1ddd
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-ci
branch
3 times, most recently
from
July 17, 2025 12:50
5ee69e3 to
850bc18
Compare
Previously, some statuses other than success (e.g. cancelled) were considered passing for the `check_required_tests` job. We can instead check directly against the `success` status, to strictly enforce that all tests must pass.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-ci
branch
from
July 17, 2025 12:56
850bc18 to
090f3d9
Compare
szokeasaurusrex
marked this pull request as ready for review
July 17, 2025 12:56
szokeasaurusrex
requested review from
sl0thentr0py and
srothh
and removed request for
a team
July 17, 2025 12:57
sl0thentr0py
approved these changes
Jul 17, 2025
srothh
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, some statuses other than success (e.g. cancelled) were considered passing for the
check_required_testsjob. See, for example, this job run, where several tests timed out, ending with cancelled status, but the final check passed.We can instead check directly against the
successstatus, to strictly enforce that all tests must pass.