Use span.data instead of measurements for token usage#4567
Merged
antonpirker merged 1 commit intomasterfrom Jul 10, 2025
Merged
Use span.data instead of measurements for token usage#4567antonpirker merged 1 commit intomasterfrom
span.data instead of measurements for token usage#4567antonpirker merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4567 +/- ##
==========================================
+ Coverage 80.72% 80.73% +0.01%
==========================================
Files 156 156
Lines 16481 16481
Branches 2801 2801
==========================================
+ Hits 13304 13306 +2
- Misses 2295 2296 +1
+ Partials 882 879 -3
|
sentrivana
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store AI token usage in
span.datainstead of deprecatedmeasurements.In
relaythere is already code in place that copies the data from the deprecatedspan.measurementstospan.dataand usesspan.datafor calculating the cost of token usage. So this PR can be deployed in a minor without risk.See also
relayPR: getsentry/relay#4768