Repository navigation
Cursor generated rules - #4493
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4493 +/- ##
==========================================
- Coverage 80.60% 80.51% -0.10%
==========================================
Files 142 142
Lines 16057 16057
Branches 2748 2748
==========================================
- Hits 12943 12928 -15
- Misses 2245 2266 +21
+ Partials 869 863 -6 |
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
This feels weird but if it makes the cursor experience better...
See comments
| - **Descriptive names**: Use clear, descriptive test function names | ||
| - **Arrange-Act-Assert**: Structure tests with setup, execution, and verification | ||
| - **Isolation**: Each test should be independent and not affect others | ||
| - **No mocking**: Never use mocks in tests |
There was a problem hiding this comment.
Sometimes there's no way around mocking
There was a problem hiding this comment.
the default tests it generated had like 5 mocks and then tested one or two lines of code so really want to avoid that. If you want to use mocks, just write the test yourself for now, if the LLM writes it it should be without mocks.
|
Web 2 should be ok after merging master |
83ddebf to
4679b0e
Compare
|
These files are either way not auto-enabled and you need to tag them to use them anyway and it's a start, we will ofc iterate on them as we learn what works best. Also the way to think about this is what it auto-generated was sort of how it thinks of the codebase anyway, now that it's in rules it's cached and costs less. And we fixed a bit of what was wrong in there. |
4679b0e to
d44241f
Compare
It also added performance and aws related files but I want to keep it simple for now.
This adds: