Skip to content

fix(redis): Use command_queue instead of command_stack if available#4404

Merged
sentrivana merged 5 commits into
masterfrom
ivana/fix-redis-2
May 20, 2025
Merged

fix(redis): Use command_queue instead of command_stack if available#4404
sentrivana merged 5 commits into
masterfrom
ivana/fix-redis-2

Conversation

@sentrivana

@sentrivana sentrivana commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit in redis-py moved away from using the Pipeline's command_stack and is now using _execution_strategy.command_queue instead. We need to adapt to use the new command source if present.

This fixes redis-latest in CI.

@codecov

codecov Bot commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (ac7646b) to head (0c318ee).
Report is 2 commits behind head on master.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2301 at 1:2550 in /__w/sentry-python/sentry-python/.junitxml
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4404      +/-   ##
==========================================
+ Coverage   80.62%   80.66%   +0.04%     
==========================================
  Files         142      142              
  Lines       15961    15966       +5     
  Branches     2726     2726              
==========================================
+ Hits        12868    12879      +11     
+ Misses       2238     2231       -7     
- Partials      855      856       +1
Files with missing lines Coverage Δ
sentry_sdk/integrations/redis/_sync_common.py 86.79% <100.00%> (+1.37%) ⬆️
sentry_sdk/integrations/redis/utils.py 92.20% <100.00%> (ø)

... and 3 files with indirect coverage changes

@sentrivana
sentrivana marked this pull request as ready for review May 20, 2025 09:10
@sentrivana
sentrivana requested a review from a team as a code owner May 20, 2025 09:10
szokeasaurusrex
szokeasaurusrex previously approved these changes May 20, 2025
View reviewed changes

@szokeasaurusrex szokeasaurusrex left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any tests for this, or will it just get "automatically" tested by the latest redis tests?

Comment thread sentry_sdk/integrations/redis/_sync_common.py Outdated
@szokeasaurusrex
szokeasaurusrex dismissed their stale review May 20, 2025 12:10

noticed a potential problem

@sentrivana @szokeasaurusrex
Update sentry_sdk/integrations/redis/_sync_common.py
8a21b3c 
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
@sentrivana

sentrivana commented May 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Do we need any tests for this, or will it just get "automatically" tested by the latest redis tests?

The command_stack version is tested by all tests running redis-py<3.1, and the command_queue version is tested by >=3.1, so this is covered.

szokeasaurusrex
szokeasaurusrex approved these changes May 20, 2025
View reviewed changes

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sentrivana
sentrivana merged commit 9582a48 into master May 20, 2025
@sentrivana
sentrivana deleted the ivana/fix-redis-2 branch May 20, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @szokeasaurusrex