Fixed sentry_patched_popen_init regarding args passed as iterators#440
Closed
lorinkoz wants to merge 2 commits into
Closed
Fixed sentry_patched_popen_init regarding args passed as iterators#440lorinkoz wants to merge 2 commits into
lorinkoz wants to merge 2 commits into
Conversation
Author
|
🛎 😃 |
Member
|
Hey, I am on vacation atm. Will check in two weeks, sorry for delay
…On Tue, Jul 23, 2019, 13:38 Lorenzo Peña ***@***.***> wrote:
🛎 😃
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#440?email_source=notifications&email_token=AAGMPRMTYMQ4T2MQQ25YMXTQA3USZA5CNFSM4IFNTUKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2S2TJA#issuecomment-514173348>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGMPRMEG4H5QGGQ2FGMY23QA3USZANCNFSM4IFNTUKA>
.
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #436
Didn't want to write another function like
_init_argumentso added aforce_setdefaultparam that enacts setting default even if there is a value already._init_argumentwith asetdefault_callbackwas currently failing becauseais a tuple and don't support item assignment. Added conversion tolistbefore calling the first_init_argument.In some cases,
argsis not even a list but a string. Wrapped in list so as not to break the formatting ofspan.description.