fix(celery): Do not send extra check-in#4395
Merged
Merged
Conversation
❌ 28 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sl0thentr0py
approved these changes
May 16, 2025
sl0thentr0py
left a comment
sl0thentr0py
left a comment
Member
There was a problem hiding this comment.
looks legit, don't know all underlying details
antonpirker
approved these changes
May 19, 2025
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Tested it with my example project and it does not what it should. (which is having only one check-in for in_progress and ok)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the RedBeatScheduler, we're sending an extra in-progress check-in at scheduler start. Since this is never followed by an ok or error check-in, the check-in is marked as timed out in Sentry.
We're patching the scheduler's
maybe_due, which (as the name implies) might not end up executing the task. This is indeed what seems to be happening --maybe_dueis run when the scheduler starts, but without scheduling the task. We don't check whethermaybe_dueactually ended up scheduling anything and always fire an in-progress check-in.Patching the scheduler's
apply_asyncinstead.Closes #4392