Increase test coverage#4393
Merged
Merged
Conversation
mgaligniana
changed the title
datetime_from_isoformat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
==========================================
+ Coverage 80.28% 80.61% +0.32%
==========================================
Files 142 142
Lines 15961 15961
Branches 2726 2726
==========================================
+ Hits 12815 12867 +52
+ Misses 2271 2238 -33
+ Partials 875 856 -19 |
mgaligniana
marked this pull request as ready for review
May 19, 2025 04:15
mgaligniana
commented
May 19, 2025
Contributor
Author
There was a problem hiding this comment.
🎗️ For some reason when I run it alone the coverage is 100%. When I run the whole test suite I get 95%
Contributor
Author
There was a problem hiding this comment.
🔍 👣 Found it. Couple of tests fail running the entire suite
antonpirker
approved these changes
May 20, 2025
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Amazing! Thanks @mgaligniana for improving our test coverage! 💯
antonpirker
enabled auto-merge (squash)
May 20, 2025 07:18
Contributor
Author
|
Thanks @antonpirker ! Anton, if it's not too much trouble, could you give me a way to contact you? For a few small Sentry questions! |
Contributor
|
sure: anton.pirker@sentry.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-3515
Summary:
Before
After
