Make all relevant types public#4315
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4315 +/- ##
==========================================
+ Coverage 80.28% 80.30% +0.01%
==========================================
Files 142 142
Lines 15925 15929 +4
Branches 2724 2724
==========================================
+ Hits 12786 12792 +6
+ Misses 2263 2262 -1
+ Partials 876 875 -1
|
6 tasks
szokeasaurusrex
approved these changes
Apr 22, 2025
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Looks good! Although, I would recommend omitting the TODO comments.
| tuple[None, None, None], | ||
| ] | ||
|
|
||
| # TODO: Make a proper type definition for this (PRs welcome!) |
Member
There was a problem hiding this comment.
[nit] I'd suggest we just remove these TODO comments and make GitHub issues for them; I think TODO comments will just get ignored
Suggested change
| # TODO: Make a proper type definition for this (PRs welcome!) |
Contributor
Author
There was a problem hiding this comment.
I will keep them. Maybe someone wants to earn some internet points and creates nice types here :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make types that users can use when configuring the SDK public.
Accompaniyng docs update: getsentry/sentry-docs#13437
Fixes #4127