Skip to content

Fixed flaky test#4165

Merged
antonpirker merged 4 commits into
masterfrom
antonpirker/fix-test
Mar 20, 2025
Merged

Fixed flaky test#4165
antonpirker merged 4 commits into
masterfrom
antonpirker/fix-test

Conversation

@antonpirker

Copy link
Copy Markdown
Contributor

The URL www.squirrelchasers.com is actually existing, so we should not access it in our tests. Hope this make the test more stable.

@antonpirker
antonpirker requested a review from sentrivana March 19, 2025 11:10
@codecov

codecov Bot commented Mar 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (f6db981) to head (7fb4b42).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4165      +/-   ##
==========================================
+ Coverage   79.49%   79.57%   +0.07%     
==========================================
  Files         141      141              
  Lines       15732    15732              
  Branches     2675     2675              
==========================================
+ Hits        12506    12518      +12     
+ Misses       2379     2368      -11     
+ Partials      847      846       -1     

see 5 files with indirect coverage changes

@antonpirker
antonpirker marked this pull request as ready for review March 19, 2025 11:22

@szokeasaurusrex szokeasaurusrex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't a more robust solution be to use a mock server? I feel like tests in general should not be depending on a real network connection, as it introduces to many opportunities for flakiness

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@antonpirker
antonpirker enabled auto-merge (squash) March 20, 2025 08:12
@antonpirker
antonpirker merged commit f76528f into master Mar 20, 2025
@antonpirker
antonpirker deleted the antonpirker/fix-test branch March 20, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants