Handle loguru msg levels that are not supported by Sentry#4147
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4147 +/- ##
==========================================
- Coverage 79.57% 79.50% -0.08%
==========================================
Files 141 141
Lines 15714 15723 +9
Branches 2671 2673 +2
==========================================
- Hits 12505 12501 -4
- Misses 2367 2377 +10
- Partials 842 845 +3
|
sentrivana
approved these changes
Mar 18, 2025
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
Looks ok, but the tests need fixing.
|
Thanks for eventually getting to this! I know it's small but I always appreciate when I don't need to see weird warnings staring back at me in the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loguru has two message levels
TRACEandSUCCESSthat are not available in Sentry breadcrumbs. This PR mapsTRACEtodebugandSUCCESStoinfoin Sentry so those breadcrumbs do not show a confusing error message in the Sentry UI.Fixes #2759