Reset DedupeIntegration's last-seen if before_send dropped the event#4142
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
- Coverage 79.58% 79.55% -0.03%
==========================================
Files 141 141
Lines 15723 15732 +9
Branches 2673 2675 +2
==========================================
+ Hits 12513 12516 +3
- Misses 2367 2370 +3
- Partials 843 846 +3
|
sentrivana
marked this pull request as ready for review
March 18, 2025 08:44
antonpirker
reviewed
Mar 18, 2025
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
I guess there code be an edge case that causes problem. (see my comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imagine an app throws an exception twice, from different places. The first exception is dropped in the user's
before_send. The second exception is not. Should the second exception appear in Sentry?The current state is that it won't, since
DedupeIntegrationwill take the first, dropped exception into account. When encountering the second exception, it'll consider it a duplicate and will drop it, even though the first exception never made it to Sentry.In this PR, we reset
DedupeIntegration'slast-seenif an event has been dropped bybefore_send, ensuring that the next exception will be reported.Closes #371