fix(debug): Take into account parent handlers for debug logger#4133
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4133 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 140 140
Lines 15636 15636
Branches 2652 2652
=======================================
Hits 12441 12441
Misses 2362 2362
Partials 833 833
|
sentrivana
marked this pull request as ready for review
March 13, 2025 15:27
antonpirker
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only check
logger.handlersfor existing handlers. This ignores any potential parent handlers. By usinghasHandlers()(docs) instead we take those into account as well.Closes #3944