Skip to content

Fix FastAPI/Starlette middleware with positional arguments. #4118

Merged
antonpirker merged 8 commits into
masterfrom
antonpirker/fix/fastapi-middleware
Mar 10, 2025
Merged

Fix FastAPI/Starlette middleware with positional arguments. #4118
antonpirker merged 8 commits into
masterfrom
antonpirker/fix/fastapi-middleware

Conversation

@antonpirker

Copy link
Copy Markdown
Contributor

Fixes #3246

@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (8672dc1) to head (63b25d9).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/starlette.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4118      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.02%     
==========================================
  Files         140      140              
  Lines       15581    15581              
  Branches     2643     2643              
==========================================
+ Hits        12397    12401       +4     
+ Misses       2345     2343       -2     
+ Partials      839      837       -2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/starlette.py 84.09% <66.66%> (ø)

... and 3 files with indirect coverage changes

Comment thread sentry_sdk/integrations/starlette.py Outdated
Comment thread sentry_sdk/integrations/starlette.py Outdated
@antonpirker
antonpirker merged commit 7deebf0 into master Mar 10, 2025
@antonpirker
antonpirker deleted the antonpirker/fix/fastapi-middleware branch March 10, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError when instantiating Starlette middleware with positional arguments

3 participants