feat(flags): remove Unleash get_variant patching code#3914
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3914 +/- ##
==========================================
- Coverage 80.20% 80.16% -0.05%
==========================================
Files 139 139
Lines 15400 15391 -9
Branches 2596 2596
==========================================
- Hits 12352 12338 -14
- Misses 2203 2208 +5
Partials 845 845
|
aliu39
changed the title
aliu39
marked this pull request as draft
January 10, 2025 18:31
aliu39
changed the title
aliu39
changed the title
aliu39
marked this pull request as ready for review
January 11, 2025 08:49
cmanallen
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3888
The original PR patched 2 methods used for evaluating feature flags,
is_enabled(simple toggle on/off) andget_variant(returns a dict of metadata, see https://docs.getunleash.io/reference/sdks/python#getting-a-variant).We want to remove all
get_variantcode since we only support boolean flag evals atm. It seems like the main usecase for variants is reading payloads (non-bool) for A/B/multivariate testing. This could lead to a lot of extraneous flags, so until it is requested and/or we support non-bool values, let's not patch this method.