Skip to content

Small contribution docs update#3909

Merged
antonpirker merged 1 commit into
masterfrom
antonpirker/releases-only-by-core-team
Jan 9, 2025
Merged

Small contribution docs update#3909
antonpirker merged 1 commit into
masterfrom
antonpirker/releases-only-by-core-team

Conversation

@antonpirker

@antonpirker antonpirker commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

@antonpirker
antonpirker enabled auto-merge (squash) January 9, 2025 13:10
@codecov

codecov Bot commented Jan 9, 2025 •
edited
Loading

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13808 1 13807 4167
View the top 1 failed tests by shortest run time 
tests.test_basics test_classmethod_tracing
Stack Traces | 0.152s run time 
tests/test_basics.py:946: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 2 == 1
E    +  where 2 = <MagicMock name='mock.start_child' id='139657650674752'>.call_count

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@antonpirker
antonpirker merged commit 4432e26 into master Jan 9, 2025
@antonpirker
antonpirker deleted the antonpirker/releases-only-by-core-team branch January 9, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonpirker @sentrivana