fix: Deepcopy flag buffer on scope fork#3882
Closed
cmanallen wants to merge 9 commits into
Closed
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
cmanallen
enabled auto-merge (squash)
December 18, 2024 21:36
Member
Author
|
@antonpirker Re-ran the test and this is now passing. Has |
ffelixg
reviewed
Dec 19, 2024
|
|
||
| self.hits = self.misses = 0 | ||
|
|
||
| def __copy__(self): |
Contributor
There was a problem hiding this comment.
If you remove this method entirely, aren't we back at square one? I.e. the cache will get polluted by changes to a copy:
def test_mutate():
cache = LRUCache(1)
cache.set(0, 0)
copy(cache).set(0, 1)
assert cache.get(0) == 0 # fails
Member
Author
There was a problem hiding this comment.
No because the call site is now using deepcopy. Which targets the dunder deepcopy method which we leave as default.
Contributor
|
Closing this in favor of solution linked here: #3852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous attempt to fix this issue focused on a related issue and assumed that it would fix this. This PR adds a test using the reproduction steps mentioned in the bug report and fixes the issue by deep copying the buffer.
Closes: #3852