feat(spotlight): Inject Spotlight button on Django#3751
Merged
Conversation
This patch expands the `SpotlightMiddleware` for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3751 +/- ##
==========================================
- Coverage 84.40% 84.29% -0.12%
==========================================
Files 136 136
Lines 14379 14418 +39
Branches 2422 2429 +7
==========================================
+ Hits 12137 12154 +17
- Misses 1491 1514 +23
+ Partials 751 750 -1
|
sentrivana
reviewed
Nov 11, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
lgtm, left some suggestions/questions
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
sentrivana
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch expands the
SpotlightMiddlewarefor Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.Ref: getsentry/spotlight#543