feat: introduce rust_tracing integration#3717
Merged
antonpirker merged 11 commits intoNov 13, 2024
Merged
Conversation
matt-codecov
commented
Oct 30, 2024
matt-codecov
force-pushed
the
matt/python-rust-tracing-integration
branch
from
October 30, 2024 18:39
dc6660e to
82d3239
Compare
❌ 3 Tests Failed:
View the full list of 3 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
matt-codecov
marked this pull request as ready for review
October 30, 2024 19:12
Contributor
Author
|
CI seems hung, not sure if that is my fault somehow or what |
matt-codecov
force-pushed
the
matt/python-rust-tracing-integration
branch
2 times, most recently
from
October 31, 2024 21:01
407d294 to
4d72832
Compare
antonpirker
reviewed
Nov 7, 2024
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
Looks very cool. I added some minor requests.
matt-codecov
force-pushed
the
matt/python-rust-tracing-integration
branch
from
November 11, 2024 19:32
ac1302a to
413c197
Compare
antonpirker
approved these changes
Nov 13, 2024
antonpirker
left a comment
antonpirker
left a comment
Contributor
There was a problem hiding this comment.
After some rework, this integration is now ready to be merged!
6 tasks
antonpirker
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 21, 2024
A new Python SDK integration was created in getsentry/sentry-python#3717 + getsentry/sentry-python#3780 and this PR documents it.
JoshuaMoelans
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 22, 2024
A new Python SDK integration was created in getsentry/sentry-python#3717 + getsentry/sentry-python#3780 and this PR documents it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR introduces a new integration that allows traces to descend into code in Rust native extensions by hooking into Rust's popular
tracingframework. it relies on the Rust native extension usingpyo3-python-tracing-subscriber, a crate i recently published under Sentry, to expose a way for the Python SDK to hook intotracing.in this screenshot, the transaction was started in Python but the rest of the span tree reflects the structure and performance of a naive fibonacci generator in Rust.
i have a
sentry-docsbranch with new docs for the integration pretty much ready to go. just want to get this merged and then add a working example topyo3-python-tracing-subscriberto link to first