feat(django): Add SpotlightMiddleware when Spotlight is enabled#3600
Merged
Conversation
This patch replaces Django's debug error page with Spotlight when it is enabled and is running. It bails when `DEBUG` is `False` or when it cannot connect to the Spotlight web server.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3600 +/- ##
==========================================
- Coverage 84.34% 84.27% -0.07%
==========================================
Files 133 133
Lines 13994 14024 +30
Branches 2951 2955 +4
==========================================
+ Hits 11803 11819 +16
- Misses 1450 1465 +15
+ Partials 741 740 -1
|
sentrivana
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces Django's debug error page with Spotlight when
it is enabled and is running. It bails when
DEBUGisFalseorwhen it cannot connect to the Spotlight web server.