feat: Add httpcore based HTTP2Transport#3588
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3588 +/- ##
==========================================
- Coverage 84.35% 84.33% -0.03%
==========================================
Files 133 133
Lines 13929 13994 +65
Branches 2937 2951 +14
==========================================
+ Hits 11750 11802 +52
- Misses 1442 1450 +8
- Partials 737 742 +5
|
BYK
commented
Oct 1, 2024
BYK
marked this pull request as ready for review
October 1, 2024 13:13
sentrivana
approved these changes
Oct 3, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
🥔 Thanks for this. Looks good, left some small comments, please take a look.
Contributor
|
Merging this as soon as CI allows. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All our ingest endpoints support HTTP/2 and some even HTTP/3 which are significantly more efficient compared to HTTP/1.1 with multiplexing and, header compression, connection reuse and 0-RTT TLS.
This patch adds an experimental
HTTP2Transportwith the help of httpcore library. It makes minimal changes to the originalHTTPTransportthat said withhttpcorewe should be able to implementasynciosupport easily and remove the worker logic (see #2824).This should also open the door for future HTTP/3 support (see encode/httpx#275).