test(starlette): Refactor shared test parametrization#3562
Merged
szokeasaurusrex merged 1 commit intoSep 24, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3562 +/- ##
==========================================
- Coverage 84.31% 84.30% -0.01%
==========================================
Files 133 133
Lines 13890 13890
Branches 2930 2930
==========================================
- Hits 11711 11710 -1
Misses 1440 1440
- Partials 739 740 +1 |
We use the same parametrization for testing FastAPI's and Starlette's `failed_request_status_codes` because the `FastApiIntegration`'s constructor is the same as `StarletteIntegration`'s constructor (the former is a subclass of the latter). Here, we refactor the test cases to define the parametrization once, then use it in both tests. This change will make some future changes simpler, since we only need to change the parameters in one place to affect the test for both frameworks.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-shared-parametrization
branch
from
September 24, 2024 11:31
ee3ca40 to
5c6c778
Compare
sentrivana
approved these changes
Sep 24, 2024
szokeasaurusrex
deleted the
szokeasaurusrex/refactor-shared-parametrization
branch
September 24, 2024 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the same parametrization for testing FastAPI's and Starlette's
failed_request_status_codesbecause theFastApiIntegration's constructor is the same asStarletteIntegration's constructor (the former is a subclass of the latter).Here, we refactor the test cases to define the parametrization once, then use it in both tests. This change will make some future changes simpler, since we only need to change the parameters in one place to affect the test for both frameworks.