Skip to content

fix(starlette): Fix failed_request_status_codes=[] #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szokeasaurusrex merged 2 commits into from
Sep 24, 2024
Merged

fix(starlette): Fix failed_request_status_codes=[] #3561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccdbffb
test(starlette): Remove invalid `failed_request_status_code` tests (#…
szokeasaurusrex Sep 24, 2024
09c6f2a
fix(starlette): Fix `failed_request_status_codes=[]` (#3561)
szokeasaurusrex Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sentry_sdk/integrations/starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,11 @@ def __init__(
)
self.transaction_style = transaction_style
self.middleware_spans = middleware_spans
self.failed_request_status_codes = failed_request_status_codes or [
range(500, 599)
]
self.failed_request_status_codes = (
[range(500, 599)]
if failed_request_status_codes is None
else failed_request_status_codes
) # type: list[HttpStatusCodeRange]

@staticmethod
def setup_once():
Expand Down
2 changes: 1 addition & 1 deletion tests/integrations/starlette/test_starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,7 +1149,7 @@ def test_span_origin(sentry_init, capture_events):
([range(400, 403), 500, 501], 405, False),
([range(400, 403), 500, 501], 501, True),
([range(400, 403), 500, 501], 503, False),
([None], 500, False),
([], 500, False),
],
)
"""Test cases for configurable status codes.
Expand Down