test(starlette): Remove invalid failed_request_status_code tests#3560
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3560 +/- ##
==========================================
+ Coverage 84.30% 84.32% +0.02%
==========================================
Files 133 133
Lines 13890 13890
Branches 2930 2930
==========================================
+ Hits 11710 11713 +3
Misses 1440 1440
+ Partials 740 737 -3 |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-invalid-tests
branch
from
September 24, 2024 11:28
8402895 to
2afe13a
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/refactor-shared-parametrization
September 24, 2024 11:28
…3560) The Starlette integration tests (as well as the FastAPI integration tests, which hit the same code path as the Starlette integration) include a test where the integrations' `failed_request_status_codes` parameter is set to `[None]`. However, since the parameter is typed as `Optional[list[HttpStatusCodeRange]]`, where `HttpStatusCodeRange = Union[int, Container[int]]`, passing `[None]` for this parameter should not be allowed, per the type hint. Thus, we should not test this input, since the behavior of passing `[None]` is not, and should not be, defined by the API.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-shared-parametrization
branch
from
September 24, 2024 11:31
ee3ca40 to
5c6c778
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-invalid-tests
branch
from
September 24, 2024 11:31
2afe13a to
ccdbffb
Compare
sentrivana
approved these changes
Sep 24, 2024
Base automatically changed from
szokeasaurusrex/refactor-shared-parametrization
to
master
September 24, 2024 12:08
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-invalid-tests
branch
from
September 24, 2024 12:10
66453a2 to
ccdbffb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Starlette integration tests (as well as the FastAPI integration tests, which hit the same code path as the Starlette integration) include a test where the integrations'
failed_request_status_codesparameter is set to[None]. However, since the parameter is typed asOptional[list[HttpStatusCodeRange]], whereHttpStatusCodeRange = Union[int, Container[int]], passing[None]for this parameter should not be allowed, per the type hint. Thus, we should not test this input, since the behavior of passing[None]is not, and likely should not be, defined by the API.Depends on #3562