fix(aiohttp): Handle invalid responses#3554
Merged
Merged
Conversation
If the request handler returns an invalid response (e.g. `None`), our SDK triggers an error because we try to access the invalid response's `status` attribute. Wrap this with a `try` block to handle the `AttributeError` and ensure the SDK does not break the app.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3554 +/- ##
==========================================
+ Coverage 84.49% 84.54% +0.05%
==========================================
Files 133 133
Lines 13840 13844 +4
Branches 2927 2927
==========================================
+ Hits 11694 11705 +11
+ Misses 1422 1415 -7
Partials 724 724
|
sentrivana
approved these changes
Sep 23, 2024
szokeasaurusrex
enabled auto-merge (squash)
September 23, 2024 08:02
szokeasaurusrex
added a commit
that referenced
this pull request
Sep 25, 2024
This test was added in #3554 to ensure that we don't break people's AIOHTTP apps when a request handler returns an invalid response. However, the test broke with a recent AIOHTTP release. After investigating, I believe the test broke because it depends on internal AIOHTTP implementation details which changed in the recent AIOHTTP release. This test likely does not add too much value anyways, since the change in #3554 includes a comment, which explains why handling the AttributeError is important, so I think we can safely remove it. Fixes #3567
szokeasaurusrex
added a commit
that referenced
this pull request
Sep 25, 2024
This test was added in #3554 to ensure that we don't break people's AIOHTTP apps when a request handler returns an invalid response. However, the test broke with a recent AIOHTTP release. After investigating, I believe the test broke because it depends on internal AIOHTTP implementation details which changed in the recent AIOHTTP release. This test likely does not add too much value anyways, since the change in #3554 includes a comment, which explains why handling the AttributeError is important, so I think we can safely remove it. Fixes #3567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the request handler returns an invalid response (e.g.
None), our SDK triggers an error because we try to access the invalid response'sstatusattribute. Wrap this with atryblock to handle theAttributeErrorand ensure the SDK does not break the app.