Fix for 'data' key in logger's extra#337
Conversation
|
Can we preserve the current behavior in this SDK? I feel like Raven's old behavior added an unnecessary layer of complexity (accessing I would've expected that you just remove the |
I thought of just removing If we still wanna preserve the current behaviour, I guess removing |
|
So what I want to understand is why you prefer Raven's behavior over sentry-sdk's behavior. I am open to either one, but we have to keep in mind that changing this behavior is a breaking change within sentry-sdk's version timeline. |
|
As I migrated from raven to new sentry-sdk, my projects stopped logging info as I was following old Raven's way to log additional data. This change is what I did to kinda cope with it. I guess Raven did unwrapping of But as you mentioned earlier, |
|
Good point. I agree and would prefer to keep sentry-sdk's current behavior wrt data unwrapping. |
This reverts commit fbe3957.
|
Thanks! |
Fixes #336