fix(api): push_scope deprecation warning#3355
Merged
Merged
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/push_scope-2-deprecation
branch
from
July 26, 2024 11:57
b74c30e to
54ad7ed
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 26, 2024
Although `push_scope` was meant to be deprecated since Sentry SDK 2.0.0, calling `push_scope` did not raise a deprecation warning. Now, it does. Fixes #3347
szokeasaurusrex
force-pushed
the
szokeasaurusrex/push_scope-1
branch
from
July 26, 2024 11:58
d09b113 to
c8e93af
Compare
sentrivana
approved these changes
Jul 26, 2024
Although `push_scope` was meant to be deprecated since Sentry SDK 2.0.0, calling `push_scope` did not raise a deprecation warning. Now, it does. Fixes #3347
szokeasaurusrex
force-pushed
the
szokeasaurusrex/push_scope-2-deprecation
branch
from
July 26, 2024 13:30
54ad7ed to
21eb829
Compare
szokeasaurusrex
enabled auto-merge (squash)
July 26, 2024 13:30
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
…y#3355) Although `push_scope` was meant to be deprecated since Sentry SDK 2.0.0, calling `push_scope` did not raise a deprecation warning. Now, it does. Fixes getsentry#3347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although
push_scopewas meant to be deprecated since SentrySDK 2.0.0, calling
push_scopedid not raise a deprecationwarning. Now, it does.
Fixes #3347