fix: fix Django ASGI integration on Python 3.12#3027
Merged
Conversation
Contributor
|
Hey @bellini666, thanks a lot for the fix! Taking a look. |
sentrivana
approved these changes
Apr 30, 2024
sentrivana
left a comment
sentrivana
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I also think porting the asgiref shim is a good way to go about this, even if asgiref is a Django dependency.
Thanks again for the fix, will merge this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading a Django ASGI application to Python 3.12 broke because of the integration not being able to identify that the middleware being called was async.
This is due to Python 3.12 replacing setting
_is_coroutine = asyncio.coroutines._is_coroutinewithinspect.markcoroutinefunctionThis ports the fix from
asgirefto make sure sentry_sdk can support multiple python versions.I thought about importing it from
asgiref, but not sure how the maintainers feel about requiring it as a dependency (although it is already a django's dependency)