feat(celery): Set "messaging.system" on span#3024
Merged
szokeasaurusrex merged 1 commit intoMay 15, 2024
Merged
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-queue-consumer-default-exchange
branch
from
April 30, 2024 15:16
f1671f5 to
67e2531
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
from
April 30, 2024 15:49
45e8f3b to
cd65142
Compare
szokeasaurusrex
changed the base branch from
szokeasaurusrex/celery-queue-consumer-default-exchange
to
szokeasaurusrex/celery-messaging-id
April 30, 2024 15:50
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
4 times, most recently
from
May 3, 2024 12:07
55ba199 to
a09959b
Compare
szokeasaurusrex
commented
May 3, 2024
| events = capture_events() | ||
|
|
||
| # Does not need to be a real URL, since we use always eager | ||
| celery.conf.broker_url = f"{system}://example.com" # noqa: E231 |
Member
Author
There was a problem hiding this comment.
Flake8 is giving a false positive E231 on the : in the string when running in CI
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
4 times, most recently
from
May 7, 2024 12:59
92846d8 to
4af0ecb
Compare
szokeasaurusrex
commented
May 7, 2024
| sentry_init( | ||
| integrations=[CeleryIntegration(propagate_traces=propagate_traces)], | ||
| **kwargs | ||
| **kwargs, |
Member
Author
There was a problem hiding this comment.
The formatter is adding this comment, and if I try to commit with the comma remove, CI fails. So I will keep it here
Contributor
There was a problem hiding this comment.
yes, I had that too at some point!
szokeasaurusrex
changed the title
szokeasaurusrex
marked this pull request as ready for review
May 7, 2024 13:05
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-id
branch
from
May 7, 2024 15:56
d5a29b9 to
df18b49
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
from
May 7, 2024 16:00
4af0ecb to
fa16def
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-id
branch
from
May 10, 2024 12:30
df18b49 to
9af5324
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
from
May 10, 2024 12:30
fa16def to
6d791c9
Compare
Set the "messaging.system" data on the "queue.process" span in the Celery integration. The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. Also, add tests for this feature. ref #2951
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
from
May 15, 2024 12:22
6d791c9 to
a02eb9c
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-id
branch
from
May 15, 2024 12:22
9af5324 to
68332d8
Compare
Base automatically changed from
szokeasaurusrex/celery-messaging-id
to
szokeasaurusrex/celery-retry-count
May 15, 2024 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
ref #2951