Skip to content

Traceback line number does not match error report line number#30

Merged
mitsuhiko merged 1 commit into
getsentry:masterfrom
masahiro331:utils-bugfix
Aug 31, 2018
Merged

Traceback line number does not match error report line number#30
mitsuhiko merged 1 commit into
getsentry:masterfrom
masahiro331:utils-bugfix

Conversation

@masahiro331

@masahiro331 masahiro331 commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

see #31

@masahiro331 masahiro331 changed the title Traceback line number does not match Traceback line number does not match error report Aug 28, 2018
@masahiro331 masahiro331 changed the title Traceback line number does not match error report Traceback line number does not match error report line number Aug 28, 2018
@untitaker

Copy link
Copy Markdown
Member

Thanks, this is a very interesting testcase! Could you add it to the testsuite in tests/? If it's not possible I'll do it later.

@masahiro331

Copy link
Copy Markdown
Contributor Author

Thanks!!
Please give me some time.
I will do my best!

@untitaker

Copy link
Copy Markdown
Member

No worries, take your time! (please note that you are not obliged, I can do it too, later)

@untitaker

Copy link
Copy Markdown
Member

Hi @masahiro331, any update on this? Please tell me if there is a way I can assist you

@mitsuhiko
mitsuhiko merged commit ccd083f into getsentry:master Aug 31, 2018
@mitsuhiko

Copy link
Copy Markdown
Contributor

Merging this now. Will add a test later.

@masahiro331

Copy link
Copy Markdown
Contributor Author

Thank you merge. I'm so sorry. I caught a cold.

Test is very difficult to write.
Can I teach me, Which values ​​should be compared

@untitaker

Copy link
Copy Markdown
Member

Hi @masahiro331, I think it would be good to use that example you showed me in the tests, like here: https://github.com/getsentry/sentry-python/blob/master/tests/test_basics.py

You would have to write something like:

events = capture_events()
try:
    main()
except:
    capture_exception()

event, = events

# check for proper stacktrace here
assert event == { ... }

@masahiro331
masahiro331 deleted the utils-bugfix branch September 4, 2018 12:36
@masahiro331

Copy link
Copy Markdown
Contributor Author

sorry ↑ miss ...

@masahiro331

Copy link
Copy Markdown
Contributor Author

Thank you advice !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants